Fixes: #5002 - individual list, given names starting with di-graphs not included #5013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arbor95
commented
Jul 26, 2024
arbor95
commented
- setting correct title
- Solution for issue Family Lists / Indi Lists: records for Given Name starting with Umlaut not shown #5002
* setting correct title * Solution for issue fisharebest#5002
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5013 +/- ##
============================================
- Coverage 33.85% 33.85% -0.01%
Complexity 11400 11400
============================================
Files 1178 1178
Lines 47561 47562 +1
============================================
Hits 16103 16103
- Misses 31458 31459 +1 ☔ View full report in Codecov by Sentry. |
fisharebest
reviewed
Aug 6, 2024
| @@ -383,7 +383,7 @@ public function handle(ServerRequestInterface $request): ResponseInterface | |||
|
|
|||
| if ($surname !== '' || $show_all === 'yes') { | |||
| if ($show_all !== 'yes') { | |||
There was a problem hiding this comment.
If we are changing this, then should we also remove the if { .. } around it?
When showing all surnames, we also want to have this new title?
There was a problem hiding this comment.
remove { } of foreach (?with break) seems not to be possible,
* Show first names title on selected all surnames. * removed braces
readd { } to foreach
fisharebest
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.